chore: Add "LGPL-3.0-only" to allowed licenses #5698
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And silence cargo-deny warnings about multiple versions of a crate, often nothing we can do about that. Signed-off-by: Graham King <grahamk@nvidia.com>
github-actions
bot
added
chore
ci
Contributor
WalkthroughThe pull request updates GitHub Actions workflow configuration and dependency license policies. The cargo-deny command adds an error-level log flag, and the deny.toml file permits LGPL-3.0-only licenses in the allow list. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@deny.toml`:
- Line 38: The repo currently lists "LGPL-3.0-only" in deny.toml; obtain
explicit legal sign‑off for permitting LGPL‑3.0‑only distribution and then
document that approval and required compliance steps: (1) add the approver,
date, and scope of approval to the repo’s license policy (e.g., LICENSES.md or a
LICENSE_APPROVALS file), (2) enumerate required obligations for consumers
(relinkable object rules, static vs dynamic linking guidance, source/notice
obligations) and any build/packaging checklist, (3) update deny.toml or the
license policy to reflect the approved status of "LGPL-3.0-only" and link to the
approval record, and (4) adjust any CI/license-checker config to accept the
license only when the approval entry is present.
🧹 Nitpick comments (1)
.github/workflows/pre-merge-rust.yml (1)
78-78: Avoid suppressing all cargo‑deny warnings; use config-based allow instead.The
-L errorflag suppresses all WARN-level logs, including legitimate cargo-deny warnings. Use the configuration file to explicitly allow multiple versions so other warnings remain visible.♻️ Suggested adjustment
- cargo-deny -L error --no-default-features check --hide-inclusion-graph licenses bans --config ${{ github.workspace }}/deny.toml + cargo-deny --no-default-features check --hide-inclusion-graph licenses bans --config ${{ github.workspace }}/deny.toml[bans] +multiple-versions = "allow" deny = [ # Ensure we don't depend on openssl { name = "native-tls" }, { name = "openssl-sys" }, ]
nv-anants
approved these changes
Jan 27, 2026
Signed-off-by: Graham King <grahamk@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And silence cargo-deny warnings about multiple versions of a crate, often nothing we can do about that.
Strangely I only got this warning locally, not in CI.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.